estruyf / vscode-front-matter

Front Matter is a CMS running straight in Visual Studio Code. Can be used with static site generators like Hugo, Jekyll, Hexo, NextJs, Gatsby, and many more...
https://frontmatter.codes
MIT License
1.93k stars 76 forks source link

Issue: DataFileHelper::process: Function yaml.safeLoad is removed in js-yaml 4. #717

Closed ReLater closed 9 months ago

ReLater commented 9 months ago

Describe the bug When I try to open in the FM Dashboard in tabulator "data" a data collection from a yaml file with snippets I can't expand it and see errors in the console:

["ERROR" - 23:11:49]  DataFileHelper::process: Function yaml.safeLoad is removed in js-yaml 4. Use yaml.load instead, which is now safe by default.
["ERROR" - 23:11:49]  π–₯π—‹π—ˆπ—‡π— 𝖬𝖺𝗍𝗍𝖾𝗋 𝖒𝖬𝖲: Something went wrong while processing the data file. Check your file and output log for more information. 

To Reproduce Steps to reproduce the behavior:

  1. Create a yaml file inside [[workspace]]/site/data/biShortcuts.yaml
  2. Enter content like this: https://github.com/GHSVS-de/hugo_layoutsghsvs/blob/main/dist/data/biShortcuts.yaml
  3. In frontmatter.json add block
...
  "frontMatter.data.files": [
    {
      "id": "biShortcuts",
      "title": "bi-Shortcode-Abkuerzung",
      "file": "[[workspace]]/site/data/biShortcuts.yaml",
      "fileType": "yaml",
      "labelField": "short",
      "schema": {
        "title": "Bi-Abkuerzung",
        "type": "object",
        "required": [
          "short",
          "icon"
        ],
        "properties": {
          "short": {
            "type": "string",
            "title": "Short"
          },
          "icon": {
            "type": "string",
            "title": "Icon"
          },
          "class": {
            "type": "string",
            "title": "CSS Class"
          }
        }
      }
    }
  ],
...
  1. Be aware of "fileType": "yaml",!
  2. Open Workspace.
  3. Open FM Dashboard.
  4. Click tabulator data.
  5. Click on collection "bi-Shortcode-Abkuerzung"
  6. Nothing happens but message "π–₯π—‹π—ˆπ—‡π— 𝖬𝖺𝗍𝗍𝖾𝗋 𝖒𝖬𝖲: Something went wrong while processing the data file. Check your file and output log for more information."
  7. Output log displays errors (see above).

Expected behavior Adding and editing of collection entries possible.

**

Additional context I know that it worked with older versions but I don't know which one because of a longer pause since October 2022 or so.

I think the error comes from here https://github.com/estruyf/vscode-front-matter/blob/f4816afa6599581751449b51d4fc2ac3be1a58dd/src/helpers/DataFileHelper.ts#L57

estruyf commented 9 months ago

Thanks @ReLater, the fix will be included in version 9.4.0.