Closed jshearer closed 2 years ago
Do we also need changes to the connector seeding stuff?
Yup good point, added
Noting also there's a big comment on this in 06_connectors.sql which could use some love / updates.
So wait, in practice this means you want me to edit the existing migration that introduces the connectors table? That seems wrong... but I'll try it and see what happens!
Edit: We talked, and I understand the intent here more clearly: what are currently called migrations are actually the equivalent of source code for the control-plane. As such, you wouldn't want to edit your source code by writing diffs, you'd want to directly edit the code. The same is true here -- migrations should be an implementation details related to deployment, rather than the primary source of truth.
Ok so I went back and made the changes "in place" on the existing schema definitions. I have a few questions:
detail
column on public.connectors
is missing in the schema definition, but present in the database (I think? I couldn't actually check prod as I can't get into supabase dashboard)06_connectors.sql
... should we just nuke it when we nuke the rest of the opengraph columns? The only thing it would say now is "these fields are manually filled out whenever we add a connector"@jgraettinger
This is step #1 of closing https://github.com/estuary/animated-carnival/issues/58
This adds
title
,logo_url
,short_description
, andrecommended
to thepublic.connectors
schema. It also modifies thelive_specs_ext
schema to remove the reference toopen_graph
, and add references to these new columns instead.This change is