estuary / animated-carnival

Other
3 stars 0 forks source link

refactor: Add internationalized metadata columns to `connectors` #63

Closed jshearer closed 2 years ago

jshearer commented 2 years ago

This is step #1 of closing https://github.com/estuary/animated-carnival/issues/58

This adds title, logo_url, short_description, and recommended to the public.connectors schema. It also modifies the live_specs_ext schema to remove the reference to open_graph, and add references to these new columns instead.


This change is Reviewable

travjenkins commented 2 years ago

Do we also need changes to the connector seeding stuff?

jshearer commented 2 years ago

Yup good point, added

jgraettinger commented 2 years ago

Noting also there's a big comment on this in 06_connectors.sql which could use some love / updates.

jshearer commented 2 years ago

So wait, in practice this means you want me to edit the existing migration that introduces the connectors table? That seems wrong... but I'll try it and see what happens!

Edit: We talked, and I understand the intent here more clearly: what are currently called migrations are actually the equivalent of source code for the control-plane. As such, you wouldn't want to edit your source code by writing diffs, you'd want to directly edit the code. The same is true here -- migrations should be an implementation details related to deployment, rather than the primary source of truth.

jshearer commented 2 years ago

Ok so I went back and made the changes "in place" on the existing schema definitions. I have a few questions:

@jgraettinger