search

estuary / connectors

Connectors for capturing data from external data sources
Other
38 stars 10 forks source link

source-hubspot-native: emit `null` instead of empty string for date and datetime #1665

Closed williamhbaker closed 2 weeks ago

williamhbaker commented 2 weeks ago

Description:

This will allow schema inference on the collection to infer the appropriate format, rather than the "" string forcing it to be a string with no format.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)

This change is Reviewable

dyaffe commented 2 weeks ago

For someone to take advantage of this that previously had the hubspot connector running, would they have to re-backfill everything from the source and destination with a notBefore?

williamhbaker commented 2 weeks ago

For someone to take advantage of this that previously had the hubspot connector running, would they have to re-backfill everything from the source and destination with a notBefore?

I believe the most direct way would be to re-capture into new collections that would have a new schema inferred, and then materialize those. Only re-backfilling the capture into the same collection would not work (without other interventions) since the inferred schema would still be type: string with no format for these fields.

dyaffe commented 2 weeks ago

Okay -- sounds like theoretically this is ready and I can suggest that.