When explicitly specifying the type as NetworkTunnel | None, we end up with an anyOf: [{ networkTunnel: ... }, { type: null }] which ends up rendering as two tabs in the UI. I realised it is possible in pydantic to not specify the type as a union with None, and still provide a default=None to mark the field as not required, so this is the solution.
Add network-tunnel binary to the Dockerfile for source-oracle-flashback. Since tests were running on the host machine I had not realised the network-tunnel is missing from the Dockerfile. Updated CI so it allows for custom Dockerfiles for python connectors. Tested this using a local run of the connector with SSH tunnelling using the docker image
Tested using JSONForm test renderer:
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Description:
NetworkTunnel | None
, we end up with ananyOf: [{ networkTunnel: ... }, { type: null }]
which ends up rendering as two tabs in the UI. I realised it is possible in pydantic to not specify the type as a union with None, and still provide adefault=None
to mark the field as not required, so this is the solution.Tested using JSONForm test renderer:
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is