Previously we would filter out schemas in code after having queried tables from all schemas. This was not the most efficient solution and would cause the error below if there were more than 1000 schemas (even if they specified advanced.schemas config):
ORA-01795: maximum number of expressions in a list is 1000
A customer actually hit this error, which was due to the filtering we do in fetch_columns on schemas.
Move the filtering logic to the fetch_tables query so that subsequently fetch_columns will also only filter on the limited schemas
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Description:
fetch_columns
on schemas.fetch_tables
query so that subsequentlyfetch_columns
will also only filter on the limited schemasWorkflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is![Reviewable](https://reviewable.io/review_button.svg)