estuary / data-plane-gateway

Other
0 stars 0 forks source link

data-plane-gateway should provision its own TLS certificates #16

Closed psFried closed 1 year ago

psFried commented 2 years ago

We've gone a few rounds trying to use an L7 Ingress or load balancer, and it's seeming like that approach is going to be super finicky, if we can get it to work at all. The challenge here is that we're trying to support multiple protocols on a single address, and the L7 balancers we've tried will either support GRPC or HTTP, but not both at the same time.

Our proposed solution:

psFried commented 2 years ago

Here's what I'm thinking for how to test and roll out this change:

@skord WDYT?

skord commented 2 years ago

That sounds good. We'll have to add the step in there early of reserving the static IP, probably a given, but want to write it down. We'll refer to it in dataPlaneGatewayV2. Removing the resources will include deleting the jsonnet as well as manually removing the static ip reservation in GCP.

psFried commented 2 years ago

Right, good call. So the updated steps would be:

jgraettinger commented 1 year ago

Can this be closed as "done"?

skord commented 1 year ago

@jgraettinger I think the title is misleading and we need to merge https://github.com/estuary/ops/pull/158 for cleanup before this can be considered complete. I might be wrong here, but it appears as Phil's comment 15 days ago indicates cleanup being done before it can be closed.

skord commented 1 year ago

estuary/ops#158 has been merged and this is closable.