estuary / flow

🌊 Continuously synchronize the systems where your data lives, to the systems where you _want_ it to live, with Estuary Flow. 🌊
https://estuary.dev
Other
530 stars 45 forks source link

Evolutions remove `notBefore` from bindings #1469

Open psFried opened 1 month ago

psFried commented 1 month ago

Steps:

We should check to see if anything else is getting cleared out accidentally, too. This issue can certainly be resolved as part of the re-framing of evolutions as part of controllers. But we can probably also fix it sooner if there were urgent need.

psFried commented 1 month ago

I looked at the evolutions code in agent and found that it's cloning the entire binding and then just incrementing the backfill counter. I really don't see how it could be removing notBefore or anything else. So I decided to try performing an evolution manually by creating a draft and inserting a row into the evolutions table. When I did that, it preserved all the notBefore fields as expected. So now I'm thinking perhaps the UI is involved.