search

estuary / flow

🌊 Continuously synchronize the systems where your data lives, to the systems where you _want_ it to live, with Estuary Flow. 🌊
https://estuary.dev
Other
530 stars 45 forks source link

Phil/no key changes #1506

Closed psFried closed 5 days ago

psFried commented 5 days ago

Description:

Re-introduces the prior behavior of rejecting any changes to the key or logical partitioning of a collection spec. We'd eventually like to allow these changes, but it seems our first go was a bit premature, since we don't yet have another way to respect evolveIncompatibleCollections: false if the key does change.

I tried to keep this change relatively localized and easy to rip out.

Workflow steps:

Publish an existing collection with a different key or logical partitioning. It should now fail and return incompatible_collections.

Documentation links affected:

n/a

Notes for reviewers:

Also includes a minor cleanup in agent-sql.

This change is Reviewable

psFried commented 5 days ago

I don't think it's ever gonna be okay to change logical partitioning of an active collection

Ok, that makes sense, and I'd agree that eventually pushing it down into validation also makes sense :+1: