Closed flavioriper closed 4 months ago
Visit the preview URL for this PR (updated for commit 30bd1aa):
https://estuary-marketing--pr211-feat-bigquery-lp-kfjgfr7q.web.app
(expires Thu, 23 May 2024 21:23:12 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e
Is this correct? It looks like the bottom of the box around the icons is cut off slightly.
Should this be prefilled with Big-Query?
I think we need to make this section go into "mobile" mode a little sooner.
@Brenosalv - can you please run a lighthouse test against the preview and include screenshots of the scores? Just want a basic idea and then I think we're good.
@Brenosalv - can you please run a lighthouse test against the preview and include screenshots of the scores? Just want a basic idea and then I think we're good.
@travjenkins Sure, follows the lighthouse screenshot for desktop device:
And for mobile device:
The performance values vary from 54 to 98, being higher for desktop devices. The SEO values from screenshots are constant.
Okay - that looks good. And performance can change a lot since it is running on your own network.
Makes sense.
Just to update you: I just updated the description and I'm waiting for the alt texts of the images.
Taking a second look now that this is a template
Can we double check that this button should hit the VS
content. I feel like this should open a new window to the dashboard.
This will be future work
Should these little blurbs all be the same between source
and destination
? Truly asking as I can see it being consistent but also could see wanting to change the content a little bit for each type.
Running desktop lighthouse for new page looks good
For now, we won't want to change that section for each. Longer-term, that likely makes sense. We don't have capacity though for it so something more generic about the platform is more fitting.
On Mon, Apr 15, 2024 at 12:30 PM Travis Jenkins @.***> wrote:
Running desktop lighthouse for new page looks good image.png (view on web) https://github.com/estuary/marketing-site/assets/270078/6f8a65d1-c100-4ed5-a792-aef4291c2b95
— Reply to this email directly, view it on GitHub https://github.com/estuary/marketing-site/pull/211#issuecomment-2057277701, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5HTFGTEF7MJXTHGQAIEPUDY5P6AZAVCNFSM6AAAAABEFAXZJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJXGI3TONZQGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Changes
/big-query
page to the sitemapTests / Screenshots