Closed travjenkins closed 5 months ago
Update: decided not to go down this path and just pull HubSpot out of PartyTown
Progress in the correct direction. However, nested props are missing so it seems partytown just populates this right away.
If you put the full hbsp.forms.create
in the partyTown forwarder you can fall the function but it does not actually do anything.
Visit the preview URL for this PR (updated for commit cb09e77):
https://estuary-marketing--pr214-travjenkins-bug-upda-mhop82b8.web.app
(expires Sun, 07 Apr 2024 21:48:19 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e
Fixes: https://github.com/estuary/marketing-site/issues/212
Changes
hub-spot-forms
from thepartyTown
loader so thatwindow.hbspt
is availablepartyTown
versionreact-hubspot-form
to not throw errorsScreenshots
The modal displays on top![image](https://github.com/estuary/marketing-site/assets/270078/dcfe1199-11f9-4d84-8dfe-856f1a57d9fd)
Book Demo modal rendering![image](https://github.com/estuary/marketing-site/assets/270078/37520a5e-49ab-4016-8c8d-50f448b775a6)
Pricing - Contact Us rendering![image](https://github.com/estuary/marketing-site/assets/270078/50688b33-a0e1-4e02-abfd-1579f4ebbe3b)
Hubspot email validation call made![image](https://github.com/estuary/marketing-site/assets/270078/a4c993bf-7f64-485a-8917-f0015f585605)
Data making it to HubSpot
![image](https://github.com/estuary/marketing-site/assets/270078/2f00897a-bca5-477d-b5a0-1d2e38866c23)