Create a reusable encapsulated modal opener - Githubissues

estuary / marketing-site

0 stars 5 forks source link

Create a reusable encapsulated modal opener #214

Closed travjenkins closed 5 months ago

travjenkins commented 5 months ago

Fixes: https://github.com/estuary/marketing-site/issues/212

Changes

Make and refactor some HubSpot related components
Remove hub-spot-forms from the partyTown loader so that window.hbspt is available
Update to the latest partyTown version
Patch the react-hubspot-form to not throw errors
Styling updated so the dialog will display above the header

Screenshots

The modal displays on top

Book Demo modal rendering

Pricing - Contact Us rendering

Hubspot email validation call made

Data making it to HubSpot

travjenkins commented 5 months ago

Update: decided not to go down this path and just pull HubSpot out of PartyTown

Progress in the correct direction. However, nested props are missing so it seems partytown just populates this right away.

travjenkins commented 5 months ago

If you put the full hbsp.forms.create in the partyTown forwarder you can fall the function but it does not actually do anything.

github-actions[bot] commented 5 months ago

Visit the preview URL for this PR (updated for commit cb09e77):

https://estuary-marketing--pr214-travjenkins-bug-upda-mhop82b8.web.app

_{(expires Sun, 07 Apr 2024 21:48:19 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e}