Feat: Eslint and prettier project setup

estuary / marketing-site

0 stars 5 forks source link

Feat: Eslint and prettier project setup #229

Closed flavioriper closed 5 months ago

flavioriper commented 5 months ago

Changes

Add Eslint config files
Add Prettier config files
Changed tsconfigfile to sanitize unused rules

Tests / Screenshots

github-actions[bot] commented 5 months ago

Visit the preview URL for this PR (updated for commit c40b7d3):

https://estuary-marketing--pr229-feat-eslint-prettier-v64oho3c.web.app

_{(expires Wed, 17 Apr 2024 20:02:28 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e}

flavioriper commented 5 months ago

Can you please add this option: 'react-hooks/exhaustive-deps': 'error'

Also, we can ignore for now but we should probably add the rule 'react/jsx-no-leaked-render': 'error' in there. I see we use this approach a lot but it is somewhat risky to be doing.

Agreed.