Add Osano back into marketing site

estuary / marketing-site

0 stars 5 forks source link

Add Osano back into marketing site #235

Closed travjenkins closed 3 months ago

travjenkins commented 3 months ago

Description

describe what you would like changed

Work required

[x] review point in the performance docs and make sure we're making this efficient
[x] add Osano onto the website
[x] run Lighthouse tests before merging and seeing what the impact will be
[x] review impact and make a decision
- [ ] Mark scripts with inline-classifications for Osano

Figma / Designs

N/A

travjenkins commented 3 months ago

For some reason - Gatsby renders page really different for develop mode

This means that when running dev locally your onPreRenderHTML won't EVER get access to the list of scripts being loaded. This makes testing out changes here really annoying.

Why they do this - I have no clue.

travjenkins commented 3 months ago

The normal static generator will make sure you have access to all the script tags before sending over. I assume they want to make sure a user does not accidentally mess with the files that are required for development... but this seems like a bad trade off as it makes developing so much harder.

travjenkins commented 3 months ago

Adding a handler to onPreRenderHTML might not work :( https://github.com/gatsbyjs/gatsby/discussions/37036

travjenkins commented 3 months ago

So adding in the onPreRenderHTML function won't work as we do not get the scripts loading back and just the slices.

travjenkins commented 3 months ago

https://github.com/estuary/marketing-site/issues/250 will replace this for now.

We can switch back to Osano once we can use inline classification (Switching to Next.JS)