Trying to get Google Analytics working better

estuary / marketing-site

0 stars 5 forks source link

Trying to get Google Analytics working better #242

Closed travjenkins closed 3 months ago

travjenkins commented 3 months ago

Changes

Remove Partytown as it is causing CORS issues and the proxied URL seems to not help
Go back to loading gtag from Google

Tests / Screenshots

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit b89d96e):

https://estuary-marketing--pr242-travjenkins-bugs-upd-6jfjxwlo.web.app

_{(expires Wed, 08 May 2024 15:52:09 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e}

travjenkins commented 3 months ago

I think we're okay with removing PartyTown now that other performance upgrades were made

travjenkins commented 3 months ago

Looking through all the lighthouse metrics I think we're good to merge this. Some of the pages dropped a bit with performance but others went up. Given we think this might be causing issues with GA reporting stuff correctly I think the trade off is alright.