estuary / marketing-site

0 stars 5 forks source link

Brenosalv/feature/add webinar popup to the blog page #269

Closed Brenosalv closed 5 months ago

Brenosalv commented 5 months ago

Issues

Changes

Figma layout

Tests / Screenshots

image

github-actions[bot] commented 5 months ago

Visit the preview URL for this PR (updated for commit 998ab96):

https://estuary-marketing--pr269-brenosalv-feature-ad-htccr455.web.app

(expires Thu, 30 May 2024 17:40:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

Brenosalv commented 5 months ago

For now we decided to implement only this popup version: image

travjenkins commented 5 months ago

One last thing - I think we need to keep if this is closed in session storage. Having this reopen every time you view a blog page after you have closed it again it is annoying.

I think keeping it in local storage might mean it never opens up again - which is a lot. So I think session storage is a nice in between.