estuary / marketing-site

0 stars 5 forks source link

Brenosalv/feature/implement-a-max-width-for-the-site #284

Closed Brenosalv closed 1 month ago

Brenosalv commented 2 months ago

Issues:

https://github.com/estuary/marketing-site/issues/255 https://github.com/estuary/marketing-site/issues/275

github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit 4fb198c):

https://estuary-marketing--pr284-brenosalv-feature-im-qjveud3g.web.app

(expires Sun, 09 Jun 2024 02:43:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

Brenosalv commented 1 month ago

Just correcting: The commit 7dd6061 was for the connector template, not blog post template.

travjenkins commented 1 month ago

Integration pages with source and destination selected are too wide

image

travjenkins commented 1 month ago

The 404 page does not follow the width image

travjenkins commented 1 month ago

When selecting source and destination the images can quickly get way too small. I think we need to make sure that "column" does not shrink down too much with the new width image

travjenkins commented 1 month ago

https://estuary-marketing--pr284-brenosalv-feature-im-qjveud3g.web.app/integrations/datadog-ingest-to-google-cloud-sql-sqlserver/

You need to use ones with longer names to see the issue

travjenkins commented 1 month ago

If we turn off nowrap on the text I think it looks okay - image

Brenosalv commented 1 month ago

If we turn off nowrap on the text I think it looks okay - image

Thanks, Travis, that's exactly the solution.

travjenkins commented 1 month ago

Sorry - found one more while testing on my home machine.

image

We should mark these connector icons with hardcoded width and height? However, that can cause the chips to overflow

image

If we allow the flex items to wrap and align them to the end it looks okay

image

I am not super strong about any specific solution though - just wanted to leave a basic idea of a quick solution

Brenosalv commented 1 month ago

Sorry - found one more while testing on my home machine. image

We should mark these connector icons with hardcoded width and height? However, that can cause the chips to overflow image

If we allow the flex items to wrap and align them to the end it looks okay image

I am not super strong about any specific solution though - just wanted to leave a basic idea of a quick solution

I see it's an issue already present in production. I like your solution but I prefer besides adding a max-width 55px to the icons, also adjusting the grid to become 3 columns earlier. Please let me know what you think about this solution. I just pushed a new commit.