estuary / marketing-site

0 stars 5 forks source link

Privacy Policy Update : May 28, 2024 #328

Closed travjenkins closed 1 month ago

travjenkins commented 1 month ago

Changes

Tests / Screenshots

Privacy

image

Terms

image

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 597c03b):

https://estuary-marketing--pr328-travjenkins-content-hesbuon3.web.app

(expires Fri, 28 Jun 2024 03:16:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

travjenkins commented 1 month ago

I'm currently naming the folders in the components directory according to the corresponding page name as Homepage folder. This way, I would consider creating a new folder called PrivacyPolicy and including a styles.ts file within it, instead of just having a file named LegalWrapper.tsx directly inside the components folder. What do you think?

Normally that is how you would name stuff. However, that is a lot of overhead for two pages where everything is contained within a single file. If they were a bit more complex that is how I would have done it for sure.