estuary / marketing-site

0 stars 5 forks source link

Brenosalv/bug/mobile-table---not-responsive #346

Closed Brenosalv closed 3 weeks ago

Brenosalv commented 4 weeks ago

316

Changes

Tests / Screenshots

Brenosalv commented 4 weeks ago

@travjenkins Please let me know your thoughts about this solution. The real change is:

Before:

.dynamic-html {
      width: 100%;
      overflow: hidden;
}

After:

.dynamic-html {
      width: 100%;
      overflow: hidden;

      .table {
        overflow-x: auto;

        @media (max-width: 620px) {
          float: none !important;
        }

        &>table {
          width: 100%;
          min-width: 400px;
          margin-top: 0;
          margin-bottom: 0;
        }
      }
    }

This way the tables are scrolling in small screen widths.

The float: none; is necessary for tables that are floatting left or right in parallel with a text (see E.g 2). It's not a problem since it's applied only for screen widths less than 620px where it makes sense to centralize any table.

Examples of blog posts for testing:

github-actions[bot] commented 4 weeks ago

Visit the preview URL for this PR (updated for commit 14fe53c):

https://estuary-marketing--pr346-brenosalv-bug-mobile-xws5p996.web.app

(expires Sun, 07 Jul 2024 17:24:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

travjenkins commented 3 weeks ago

Can we remove the extra space around the table on mobile to make it a bit extra readable?

image