estuary / marketing-site

0 stars 5 forks source link

Brenosalv/bug/menu-bug-width-error #361

Closed Brenosalv closed 2 weeks ago

Brenosalv commented 2 weeks ago

352

Changes

Add missing content to menu on mobile;
Add scroll when screen is too small.

Tests / Screenshots

github-actions[bot] commented 2 weeks ago

Visit the preview URL for this PR (updated for commit 9cc2d8d):

https://estuary-marketing--pr361-brenosalv-bug-menu-b-fbh9assx.web.app

_{(expires Sat, 20 Jul 2024 15:35:06 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e}

travjenkins commented 2 weeks ago

When the window is 1025px wide the hover state of Documents link ends up wrapping. I think we should prevent this from wrapping but have a max width on the item so the text is partially hidden.

travjenkins commented 2 weeks ago

What new content is being shown on mobile?

Brenosalv commented 2 weeks ago

What new content is being shown on mobile?

@travjenkins Sorry, it was not clear. The missing content was the columns that disappeared when Sourabh zoomed in: https://www.awesomescreenshot.com/video/28642343?key=e3a5df5df5900fa3beb6abb9c5550837

Brenosalv commented 2 weeks ago

When the window is 1025px wide the hover state of Documents link ends up wrapping. I think we should prevent this from wrapping but have a max width on the item so the text is partially hidden.

@travjenkins I'll create an issue for this.