Closed kiahna-tucker closed 3 weeks ago
The issues directly below are advanced by this PR: https://github.com/estuary/ui/issues/1142
The following features are included in this PR:
Display an error alert in the alert subscription dialog when the call to create and/or delete a subscription fails.
Broaden the scope of the alert subscription dialog error component.
Approaches to testing are as follows:
Validate that an error is displayed when the creation of a subscription fails.
Validate that an error is displayed when the deletion of a subscription fails.
Validate that errors encountered when clicking the Save CTA are non-blocking and cleared on a subsequent click.
Validate that an error is displayed when the alert subscriptions dialog fails to initialize and the emails field and save button are disabled.
N/A
Dialog save error alert | Subscription deleted
Dialog save error alert | Subscription created and deleted
Dialog save error alert | Subscription created
Issues
The issues directly below are advanced by this PR: https://github.com/estuary/ui/issues/1142
Changes
1142
The following features are included in this PR:
Display an error alert in the alert subscription dialog when the call to create and/or delete a subscription fails.
Broaden the scope of the alert subscription dialog error component.
Tests
Manually tested
Approaches to testing are as follows:
Validate that an error is displayed when the creation of a subscription fails.
Validate that an error is displayed when the deletion of a subscription fails.
Validate that errors encountered when clicking the Save CTA are non-blocking and cleared on a subsequent click.
Validate that an error is displayed when the alert subscriptions dialog fails to initialize and the emails field and save button are disabled.
Automated tests
N/A
Playwright tests ran locally
Screenshots
Dialog save error alert | Subscription deleted
Dialog save error alert | Subscription created and deleted
Dialog save error alert | Subscription created