Add support for `onIncompatibleSchemaChange` in the UI - Githubissues

estuary / ui

A web based UI to assist in working with Estuary Flow

https://dashboard.estuary.dev/

Other

12 stars 1 forks source link

Add support for `onIncompatibleSchemaChange` in the UI #1303

Closed travjenkins closed 1 month ago

travjenkins commented 1 month ago

Issues

Implements: https://github.com/estuary/ui/issues/1283 Contributes: https://github.com/estuary/ui/issues/1221

Changes

1283

Added the onIncompatibleSchemaChange section to the bottom of the form. This currently acts like backfill and required a draft
Hide the section for now as the backend still needs some work in discovers

1221

Update store to stop using get within set as that can cause issues where two different states are being references at once

Misc

Added some typing for the auto complete defaults
Updated so there is a default autocomplete without virtualization

Tests

Manually tested

scenarios you manually tested

Automated tests

unit testing covered

Playwright tests ran locally

[ ] Admin
[ ] Captures
[ ] Collections
[ ] HomePage
[ ] Login
[ ] Materialization

Screenshots

Invalid setting

Failed to update

travjenkins commented 1 month ago

Not really - this is just made to follow the collection key editing since it is also an autocomplete.

Not sure how I feel about using the menu styling here as it might be a bit confusing... but not totally against it.