Removing all disabled bindings based on the draft during save - Githubissues

estuary / ui

A web based UI to assist in working with Estuary Flow

https://dashboard.estuary.dev/

Other

12 stars 1 forks source link

Removing all disabled bindings based on the draft during save #1306

Closed travjenkins closed 1 month ago

travjenkins commented 1 month ago

Issues

https://github.com/estuary/ui/issues/1305

Changes

1305

No longer keep a list of disabled collections
Just read the bindings directly from the draft
- Kinda sucks we have to loop over but this is by far the safest approach

Tests

Manually tested

Discovered and rediscovered with postgres locally

Automated tests

unit testing covered

Playwright tests ran locally

[ ] Admin
[x] Captures
[ ] Collections
[ ] HomePage
[ ] Login
[x] Materialization

Screenshots

Edited capture and did a rediscover. Left all the previously disabled disabled and those are now removed.

travjenkins commented 1 month ago

Basically a more fleshed out approach than what was added with https://github.com/estuary/ui/pull/1184 . This does feel a lot more "heavy" but should help keeping users from facing any issues related to missing keys.