search

estum / growlyflash

Growl-styled flash messages for Ruby on Rails and Bootstrap
MIT License
58 stars 34 forks source link

Make title customizable again #34

Closed ngarbezza closed 7 years ago

ngarbezza commented 8 years ago

A really small change, but that ? made the title to be always displayed no matter the value of the title property.

I also tested it on version 0.8.4.1 (before it was title instead of title?), and it worked as expected.

I'm not an expert on CoffeeScript so any suggestion is welcome!

yurijmi commented 8 years ago

Was going to create the same pull request and saw this one. Basically ? in the end means that property is not null, not that it's true. Merge asap

k00ka commented 8 years ago

This works (for now):

Growlyflash.defaults = $.extend on, Growlyflash.defaults, title: null

-OR-

Growlyflash.defaults = $.extend(true, Growlyflash.defaults, { title: null });

yurijmi commented 8 years ago

Seems like @estum implemented this PR: 42f1093378b40874100e0a6b53c2ba66f685b22e