search

esvit / ng-table

Simple table with sorting and filtering on AngularJS
http://esvit.github.io/ng-table
BSD 3-Clause "New" or "Revised" License
2.77k stars 851 forks source link

Missing Bootstrap dependency #901

Closed djpcoc closed 7 years ago

djpcoc commented 8 years ago

A Bootstrap pagination tag is used in line 9 of src/browser/pager.html.

<ul ng-if="pages.length" class="pagination ng-table-pagination">

Yet no Bootstrap dependency is declared in bower.json which results in Bootstrap being loaded in after ng-table. The following code then has no affect as it is overwritten by Bootstrap styling.

.ng-table-pagination { margin-top: 0; }

christianacca commented 7 years ago

I'm on the fence as to whether bootstrap should be included as a dependency.

The only dependency that ng-table has is on bootstrap styles. Including a dependency on the full bootstrap package seems the wrong thing to do.

One option would be to include a dependency on bootstrap-css-only package. But then what about those apps that want to use bootstrap-sass - ng-table has "forced" an unwanted dependency on the app.

So I don't think there is necessarily a right solution for the current feature set of package managers.

christianacca commented 7 years ago

Oh, and also a reminder bower is no longer supported by ng-table