search

eswick / harbor

OS X-style dock redesigned for touch screens
Other
49 stars 18 forks source link

Removed redundant a labelView hidden #1

Open wizages opened 9 years ago

wizages commented 9 years ago

This could issues where that other tweaks may use this and since you don't check if your tweak is enabled this is hell of bad practice.... Defiantly since you call it after %orig;

eswick commented 8 years ago

If you move an app outside of the dock and back to the home screen, the label will remain hidden without this code.

wizages commented 8 years ago

Try this instead I get what you mean haha.

eswick commented 8 years ago

Isn't that the same as before, though? What are you trying to accomplish?

wizages commented 8 years ago

No I moved the if statement into the enable. Currently what your tweak is doing is it is preventing any other tweak from using the label hidden function because you call it after the layout is done being set up. And the worst part is you arent even checking if your tweak is enabled so no one can use this hidden function because you just automatically set it to be not hidden.

eswick commented 8 years ago

But the bug would still be present when Harbor is enabled, would it not?

wizages commented 8 years ago

I compiled the tweak and made sure it all works. This is a fix that will enable me to fix label notify for my next update!