search

esx-framework / esx_core

Official Repo For core resources for esx-legacy
https://documentation.esx-framework.org/
GNU General Public License v3.0
368 stars 733 forks source link

chore(identity): added middle name feature #1319

Closed nwvh closed 3 weeks ago

nwvh commented 7 months ago

Adds option for players to choose a middle name (two first names) in the character registration UI

Gellipapa commented 7 months ago

Hi! @nwvh Thanks, but here you need to better separate the code, so outsource the logic into a method and use it that way, by default this should be a configurable option and print is included in the code you opened for PR.

Gellipapa commented 3 weeks ago

Hi! @nwvh We can't accept this, you probably haven't even tested it because it includes the prints.