esx-framework / esx_property

GNU General Public License v3.0
8 stars 23 forks source link

ox-Inventory storage sync issue on property deletion #17

Open lily-de-vries opened 1 year ago

lily-de-vries commented 1 year ago

Describe the bug Currently the PropertyId is the iteration / position of the property within the "properies.json" file. When removing a property all existing properties greater then the one that has been removed will decrease one in value creating issues with OX_Inventory stashes. In order for OX_inventory stashes to work the Property id needs to be a static id.

To Reproduce

  1. Create two or more properties.
  2. Enter house number two and notice the stash id: (property-2)
  3. Leave house number two and remove house number one using the admin menu.
  4. Enter house number two again and notice the stash id: (property-1)

Expected behavior When deleting a property all properties with a greater property id should keep their property ID in order not to lose their stashes/storage contents.

Screenshots

Debug Info (please complete the following information):

Additional information: Fixed it on our project by adding a static Id for each property.