search

et-nik / gameap

Game Admin Panel (GameAP) is the opensource game servers control panel.
https://gameap.com
99 stars 22 forks source link

Remove sofa/eloquence-validable package #26

Closed et-nik closed 4 years ago

et-nik commented 4 years ago

Remove sofa/eloquence-validable package. The package contains many bugs and unstable things.

Reasons:

  1. See https://github.com/et-nik/gameap/issues/2
  2. Factory create not working correctly. Tests sometimes fail: 
    
Caused by
ReflectionException: Class config does not exist

/home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Container/Container.php:803 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Container/Container.php:681 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Container/Container.php:629 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:776 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Container/Container.php:1245 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php:270 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php:101 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php:77 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Validation/DatabasePresenceVerifier.php:125 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Validation/DatabasePresenceVerifier.php:49 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Validation/Concerns/ValidatesAttributes.php:756 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Validation/Validator.php:457 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Validation/Validator.php:300 /home/nikita/Git/gameap/vendor/sofa/eloquence-validable/src/Validable.php:69 /home/nikita/Git/gameap/vendor/sofa/eloquence-validable/src/Validable/Observer.php:31 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:366 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:196 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:169 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasEvents.php:188 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:787 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:667 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Database/Eloquent/FactoryBuilder.php:219 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Support/Traits/EnumeratesValues.php:176 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Database/Eloquent/FactoryBuilder.php:220 /home/nikita/Git/gameap/vendor/laravel/framework/src/Illuminate/Database/Eloquent/FactoryBuilder.php:181 /home/nikita/Git/gameap/tests/Feature/ServersPermissionsTest.php:40

et-nik commented 4 years ago

Removed