search

eta-dev / eta-docs

Documentation website for the Eta template engine
https://eta.js.org
7 stars 18 forks source link

Eta vs Ejs link invalidity #52

Closed atomisadev closed 2 years ago

atomisadev commented 2 years ago

Describe the bug Inside the Eta vs ejs, the link (https://ghcdn.rawgit.org/eta-dev/eta/694976ffcfbe5fc2e5ae3f891549849a3bba9fdd/browser-tests/benchmark.html) directs to a spam website. It would be helpful and best if it were replaced with the accurate link, or removed totally.

To Reproduce Steps to reproduce the behavior:

  1. Open the eta website
  2. Go to this link
  3. Look at the link after "Check out these benchmarks:"

Expected behavior Open a page showcasing the benchmarks compared to EJS.

Package & Environment Details

shadowtime2000 commented 2 years ago

Yeah, the CDN we used to serve benchmark got swapped but I guess we forgot to change it in the docs. If you want to change this yourself, you can do it, otherwise I'll get it done soon.

Since this has to do with the documentation website, I'm going to transfer the issue there.

diegoacs0 commented 2 years ago

Hi @shadowtime2000 ! I have already sent a pull request for changing the actual CDN, pls consider taking a look at https://github.com/eta-dev/eta-docs/pull/50

shadowtime2000 commented 2 years ago

Closed by #50