Closed muan closed 1 year ago
@muan wow, this is a fascinating issue! Thank you for contributing a fix.
Will you amend your last commit message or create a new commit message to align with the Commitizen spec? i.e., fix: remove bun as a key and reorder instead
or feat: add Bun support
. This is required for the build to pass.
I'll then be happy to merge this!
I've squashed them and amended the commit message. 👍🏻 Thanks for the quick turnaround.
@muan thank you! Just merged and will release a new minor version.
Ref: #181
Minimum test file:
When running with Node
node test.js
When running with Bun
bun run test.js
Note the
/dist/browser.umd.js
. This is due to howbun
resolves files. It's simply by the order ofexports
keys and it's only ifexports
does not exist does it fallback tomodule
.I can't seem to track down a relevant issue in Bun so this is the best I can come up with for now. 🤷🏻♀️Tracked https://github.com/oven-sh/bun/issues/2357.With this fix direct applied inside of
node_modules/eta
, the template file resolution is fixed.