etal / cnvkit

Copy number variant detection from targeted DNA sequencing

http://cnvkit.readthedocs.org

Other

540 stars 164 forks source link

Additional heatmap refactor #632

Closed tskir closed 3 years ago

tskir commented 3 years ago

Based on work by @tetedange13 in #625. Additional changes:

Reverted to the original colormap specified by plots.cvg2rgb
Added back support for the do_desaturate parameter
Various additional refactoring and cleaning up

Closes #35.

tskir commented 3 years ago

Some test plots, to make sure things still work:

`heatmap` (defaults)

`heatmap --vertical`

`heatmap --by-bin`

`heatmap --desaturate`

`heatmap -c chr6`

tskir commented 3 years ago

Thank you once again @tetedange13 for initiating this work! I'm pretty sure that without this impetus coming from you, the heatmap issue wouldn't have been done for many more years :)

tetedange13 commented 3 years ago

Hi @tskir ,

Very nice idea to create a different ColorMap according to desaturate flag => More algorithmically efficient to map original log_values against a limited scale, rather than transforming each of them beforehand

Kind regards. Felix.

tskir commented 3 years ago

All changes from this PR are already incorporated in #625, closing

etal / cnvkit

Additional heatmap refactor #632

heatmap (defaults)

heatmap --vertical

heatmap --by-bin

heatmap --desaturate

heatmap -c chr6

`heatmap` (defaults)

`heatmap --vertical`

`heatmap --by-bin`

`heatmap --desaturate`

`heatmap -c chr6`