etal / cnvkit

Copy number variant detection from targeted DNA sequencing
http://cnvkit.readthedocs.org
Other
540 stars 164 forks source link

Diagram: switches for limiting by chromosome and for disabling gene labels #634

Closed tetedange13 closed 3 years ago

tetedange13 commented 3 years ago

Enhancement on diagram regarding #629

Default:

211461558_S6-diagram2-1

With --no-gene-labels on:

211461558_S6-diagram3-1

Closes #628. Closes #629.

tskir commented 3 years ago

Thanks Felix, everything looks good to me!

tetedange13 commented 3 years ago

Commit e8470dd218ce4e79d6fc42777d0c741abfbb73e3 should implement a feature discussed here => Display a single chromosome instead of all on diagram (exactly same display as in tskir's comment with awk-filtered ".cnr") => I implemented like scatter -c, except "start", "end" are ignored from unpacked range => Works also with --no-gene-labels

Kind regards. Felix.

tetedange13 commented 3 years ago

Hi @etal,

Thanks for your code review ! => I decided to not set metavar= parameter at all => This way this part from cnvkit.py diagram --help is pretty self-explanatory:

  -c CHROMOSOME, --chromosome CHROMOSOME
                        Chromosome to display, e.g. 'chr1' (no chromosomal range allowed)

Looking good to you? Have a nice day. Felix.