Makefile portability: use variables for Rscript and Python, and set --rscript-path explicitly

etal / cnvkit

Copy number variant detection from targeted DNA sequencing

http://cnvkit.readthedocs.org

Other

520 stars 163 forks source link

Open etal opened 2 years ago

etal commented 2 years ago

Via #661, change the test Makefile to be more portable:

Similar to the current line 5 of the Makefile where the cnvkit command is specified,

define a variable python=python
define a variable rscript=Rscript
in each segment command, explicitly set by default --rscript-path $(rscript)

tetedange13 commented 2 years ago

Hi @etal,

I already had a branch adressing this on my fork of CNVkit, I will submit a PR as soon as possible !

Have a nice day. Felix.

tetedange13 commented 2 years ago

This adress #666 too (even if already closed)

Kind regards, Felix.