etal / cnvkit

Copy number variant detection from targeted DNA sequencing
http://cnvkit.readthedocs.org
Other
501 stars 162 forks source link

Smoothing window fraction fix results in noisier data in targeted sequencing panel? #859

Open kkchau opened 7 months ago

kkchau commented 7 months ago

We're currently evaluating an update from version 0.9.9 to 0.9.10. However, we're seeing some increased noise among the ratios and resulting in an increased rate of false positives. Specifically, looking at the IQRs:

image

We've traced it back to this commit; I noticed that the window fraction now defaults to a limit of 0.01 (from the flat 0.1). Could this be under-correcting the log2 ratios during the fix step?

$ wc -l sample.target.coverage.cnn
43719 sample.target.coverage.cnn

$ wc -l sample.antitarget.coverage.cnn
3143 sample.antitarget.coverage.cnn

$ cnvkit.py fix --no-gc sample.target.coverage.cnn sample.antitarget.coverage.cnn sample.reference.cnn -o sample.cnr -i sample

I've opened up a PR to allow manual tuning of this parameter during the fix step: https://github.com/etal/cnvkit/pull/860

etal commented 6 months ago

It could be under-correcting for GC and repeats overall. My aim in that commit was to improve performance on bins with extreme GC, where e.g. Picard showed there was still a correlation between GC content and coverage depth, by using a smaller window where there were enough data points. You have better benchmarking datasets on hand than I do at this point, so if you're seeing a deterioration, then I hope your PR gets you back to where you need to be.

I'm also curious if you find the original 10% was optimal or another window size is even better on today's data.