etalab / dashboard_api_entreprise

Dashboard (statut du service et espace client/admin) de API Entreprise
https://dashboard.entreprise.api.gouv.fr
3 stars 3 forks source link

Added WAIT before loading of apientreprise status #15

Closed Samuelfaure closed 6 years ago

Samuelfaure commented 6 years ago

So I know double ternaries are bad but I feel that for once it is justified.

Also I know putting HTML class name in all-caps is bad but it saves a function :D

thimy commented 6 years ago

Meh, I'd rather have a text-transform: uppercase on the span honestly.

Samuelfaure commented 6 years ago

I didnt know that property, I'll try it :) Also there is an issue with the store that I forgot to fix.

thimy commented 6 years ago

You didn't have to close the PR, you can mark it as WIP so nobody touches it!