search

etalab / noms-de-domaine-organismes-secteur-public

Liste de noms de domaine d'organismes publics
Other
22 stars 15 forks source link

Rename domaines-organismes-publics.txt to urls.txt #24

Closed JulienPalard closed 2 years ago

JulienPalard commented 2 years ago

As I said during the last meetup, as this file contained "domain names that are accessible using HTTP or HTTPS" it should probably better contain URLs instead and be named more clearly, to ease the understanding of this repo to newcomers.

The project name don't have to change: the project still lists domain names (in the source/ directory).

And from those domain names we can do many thing (scan for SSH, SMTP, HTTP, ...). Today we're only scanning for HTTP services, but in the future, if the need arises, we could add smtp.txt, ssh.txt, ... with their own formats, needs, ...

I had to adapt various scripts, don't hesitate to look at the commits individually for better readability.

bzg commented 2 years ago

LGTM. CC @revolunet @kuczynski @villesinternet to double-check.

Can we agree that such PRs needs review and validation by at least three maintainers?

This is just a temporary clause to ensure no one feels left behind, we can of course update these rules later on.

JulienPalard commented 2 years ago

Can we agree that such PRs needs review and validation by at least three maintainers?

Yes, gladly!