etalab / notebooks

🤓 📓 📊
4 stars 4 forks source link

Update irve.ipynb #4

Closed Stefal closed 4 years ago

Stefal commented 4 years ago

remove unwanted spaces

In some data, there is a trailing space on "date_maj" (https://www.data.gouv.fr/fr/datasets/r/30155455-de66-4bd2-a242-3217fd6e7489) What is preferable? Asking for a correction on the source, or just add a strip() like in this PR?

abulte commented 4 years ago

Looks good, thanks!

I guess this should be pushed on both ends. As long as all (or most) files are not correctly formatted, we should do our best to include as many data as possible. But if it's fixed at the source level it's better. FYI only 1 IRVE file is perfectly valid on data.gouv.fr right now.