etalab / piaf

Question Answering annotation platform - Plateforme d'annotation
https://piaf.etalab.studio
MIT License
88 stars 21 forks source link

Added npm install before npm run build #33

Closed psorianom closed 3 years ago

psorianom commented 3 years ago

hi! In order to run the build of the frontend, I added to the Makefile the command needed to install the dependencies, as it is also done here https://github.com/etalab/piaf/blob/9d1307268dddc7be60e11f1a2fbd203c28ecb2fc/tools/dev-webpack.sh#L17

Once the modules required installed, the building runs without problems. There are some differences with what is done in the above dev-webpack.sh file, namely the working directory used in the Makefile and the dev-webpack files are different.

As a side note, the Dockerfile seems obsolete (it references paths that no longer exist) plus I think that it is not used by docker-compose.yml?