Docker compose

[Tristramg]

partial_fix etalab/transport-site#184

[Tristramg]

Maybe the cleanner way would be to do a mv /app/target/dt*jar /app/dt.jar? What do you think ?

On 8 March 2018 at 16:40, Mauko Quiroga notifications@github.com wrote:

@maukoquiroga commented on this pull request.

In datatools/Dockerfile https://github.com/etalab/transport-ops/pull/1#discussion_r173196197:

@@ -0,0 +1,11 @@ +FROM openjdk:10-jre-slim + +RUN apt-get update \

• && apt-get --yes upgrade \
• && apt-get --yes install git maven +RUN git clone -b fix_graphql_spec https://github.com/l-vincent-l/datatools-server.git /app \
• && cd /app && mvn -Dmaven.test.skip=true package

• +COPY *.yml /app/configuration/

• +ENTRYPOINT [ "java", "-jar", "/app/target/dt-57520e3.jar", "/app/configuration/env.yml", "/app/configuration/server.yml"]

You could use something like git rev-parse --short HEAD or I don't know how to interpolate with Docker.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/etalab/transport-ops/pull/1#discussion_r173196197, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAvyzWRGpuGanyVi7cqFWdhp34cWQZNks5tcVDxgaJpZM4SixQp .

[bonjourmauko]

Sounds good!

[Tristramg]

Changed

[bonjourmauko]

Cannot make it work:

That's probably because betagouv/datatools does not exist.

Also, to be more precise, I suggest we add something like this to the README:

docker-machine create datatools
docker-machine start datatools
docker-compose up datatools

[Tristramg]

This is an :chicken: :egg: situation. I wanted to build the image on dockerhub, but it can’t build it as long as the Dockerfile is not provided :/ let’s talk about it when I’ll be at work

docker-machine is a command specific to macOS, isn’t it ?

[Tristramg]

• I pushed the image on dockerhub, it should work now
• The readme has been updated
• I changed the Dockerfile to reduce the size from 4xx Mb down to 220 Mb