Add tests - Githubissues

etalab / transport-topo

Tool to manipulate data in https://topo.transport.data.gouv.fr

MIT License

6 stars 3 forks source link

Add tests #5

Closed Tristramg closed 5 years ago

Tristramg commented 5 years ago

As the tool is heavily dependent on an instance of wikimedia and its api and sparql service, integration tests are probably the most important.

This requires :

[ ] launch a docker instance of all services (can we user the docker-compose as basis?)
[ ] populate it with the basic identities and properties (can it be included in the docker ?)
[ ] test individual functions (search…)
[ ] end-to-end test (idempotence of importing a gtfs file…)

antoine-de commented 5 years ago

seems great!

For the technical part, I've tried https://github.com/testcontainers on a project. It was simple (no dependency to docker-compose), but not that bad, apart from some bad container cleaning in some cases.

Else we've implemented one wrapper for mimir by hand, it's not very complicated.

I've seen integration tests in python using docker-compose and It seems real nice, but I've not seen anything like this in rust 😢

How many container are needed? And do they depend on each other?

Tristramg commented 5 years ago

Let’s consider this done, and make more specific issues