search

etalab / transport-validator

GTFS validator
https://transport.data.gouv.fr/validation/
MIT License
37 stars 10 forks source link

Add an information telling that a trip has no shape #162

Closed antoine-de closed 1 year ago

antoine-de commented 1 year ago

Closes #122

It's only an information as it's completly valid

antoine-de commented 1 year ago

ping @AntoineAugusti , do you want to review this or can I merge it?

AntoineAugusti commented 1 year ago

Wondering if this is the best approach. If we have a large number of trips, we will emit a very large payload for each trip. Would it be best to emit metadata, with a ratio of trips without shapes?

antoine-de commented 1 year ago

yes, you're right it's not a bad idea a global stat will be enough, I'll change this :+1:

antoine-de commented 1 year ago

Add a trips_with_shape_count metadata

Since it's quite a common thing not ot have a shape for trips Instead of a noisy issue, add a global stat.

Count the number of trips with a shape (not wihtout) since it's more consistent with the other metadata.

antoine-de commented 1 year ago

ping @AntoineAugusti does that seems ok for you?

AntoineAugusti commented 1 year ago

LGTM, thanks!