search

etalab / transport-validator

GTFS validator
https://transport.data.gouv.fr/validation/
MIT License
37 stars 10 forks source link

Add a new rule to check the stop sequences of a trip #174

Closed antoine-de closed 10 months ago

antoine-de commented 10 months ago

In the documentation the stop_sequences of a trip are the order of the stoptimes and they should all be different.

I got bited by a malformed test due to this, so this adds a new rule to check this.

AntoineAugusti commented 10 months ago

Please wait before merging this PR a few days https://github.com/etalab/transport-validator/pull/175#issuecomment-1783101955

AntoineAugusti commented 10 months ago

I've opened a PR on transport.data.gouv.fr to handle this new rule, thanks! https://github.com/etalab/transport-site/pull/3593 You can take a look and review it if you feel like it.

Would it be possible to share a sample JSON payload when adding a new rule? It would be helpful to have an idea of what will be the output to craft error messages/views.

antoine-de commented 10 months ago

thanks!

sure, I'll try to think about the json in the next PR :+1:

AntoineAugusti commented 10 months ago

Feel free to 🚢 when you want