search

etalab / transport-validator

GTFS validator
https://transport.data.gouv.fr/validation/
MIT License
37 stars 10 forks source link

Bump gtfs structure version #175

Closed antoine-de closed 10 months ago

antoine-de commented 10 months ago

Bump GTFS structure version, gaining all the memory optimization that were done in the library

Reading a IDFM dataset

From the main branch, the peak memory was 2 221 228

From this branch, the peak memory was 1 828 052

Also bump geo version, since there is a new one (and the old one was breaking the compilation with a weird max recursion bug).

thbar commented 10 months ago

Nice! Thank you for the improvement!

antoine-de commented 10 months ago

@AntoineAugusti @thbar

are you ok if we merge both this PR and #174 on monday? I'll try to also do a whole dependency update and https://github.com/etalab/transport-validator/issues/160 next week

AntoineAugusti commented 10 months ago

@antoine-de Can you wait to merge #174 at least a week? I need to review if we need to update the UI/some translations on transport.data.gouv.fr to deal with this new error.

antoine-de commented 10 months ago

yes sure, it can wait :+1:

antoine-de commented 10 months ago

linked to https://github.com/etalab/transport-validator/issues/172 (but I don't know if we can close it, as we'll need to see if it's enough)