etalab / transport-validator

GTFS validator
https://transport.data.gouv.fr/validation/
MIT License
38 stars 10 forks source link

Move stats in a `metadata.stats` objects #192

Closed antoine-de closed 8 months ago

antoine-de commented 8 months ago

And add more counts:

There is no fare_rules yet, they are not handled by gtfs structures yet

fixes #188 #189 #190 and partially #191 since we need to handle fare_rules

antoine-de commented 8 months ago

I added the fare rules count too as it has been merged in gtfs-structures (in https://github.com/rust-transit/gtfs-structure/pull/157)

By curiosity, do you know if there are producers that have implemented the fares v2 model?

AntoineAugusti commented 8 months ago

Thanks for the changes!

By curiosity, do you know if there are producers that have implemented the fares v2 model?

Not yet 😢 Grand Est / Fluo may be the first in the coming months, they are working with Cityway on it.

AntoineAugusti commented 8 months ago

@antoine-de Can you push the latest commit on the stats branch? To make sure things are fixed 👌

antoine-de commented 8 months ago

done, sorry forgot this

antoine-de commented 8 months ago

nice, can I merge?

AntoineAugusti commented 8 months ago

Yup, looks good.

Should we bump the version? Or in the next PR when removing attributes?

antoine-de commented 8 months ago

since it's a binary and not a library, we have never kept clean version in this, but you're right, maybe we can update the version after removing the fields