search

etalab / transport-validator

GTFS validator
https://transport.data.gouv.fr/validation/
MIT License
37 stars 10 forks source link

Remove legacy fields #194

Closed antoine-de closed 5 months ago

antoine-de commented 6 months ago

linked to https://github.com/etalab/transport-validator/pull/192#discussion_r1494512645

Also bump the version to 0.3.0 since removing fields is a breaking change.

And cargo update so we can close all dependabot PRs.

Can be merged once #192 is integrated by transport-site

AntoineAugusti commented 6 months ago

https://github.com/etalab/transport-site/pull/3779 needs to be merged first (likely next week)

antoine-de commented 6 months ago

Normally the readme has been updated in the last PR in the stat section (https://github.com/etalab/transport-validator/blob/master/readme.md#metadata), tell me if you want me to add/remove some stuff.

For the fork, it's a habit I have, by default, I prefer newer to push to the main repository, does it bother you?

Pi-Cla commented 5 months ago

@antoine-de I just checked your branch with cargo audit and it seems it needs another cargo update to get rid of this advisory: https://rustsec.org/advisories/RUSTSEC-2024-0019

antoine-de commented 5 months ago

oh, you're rght, I updated the .lock again, thanks

antoine-de commented 5 months ago

@AntoineAugusti do you know why the github actions are not triggered ? is it because I pushed on a fork?

AntoineAugusti commented 5 months ago

@antoine-de Should be good now!

Let me check one more time on transport-site if we stopped using legacy fields before merging 😄