search

etalab / transport-validator

GTFS validator
https://transport.data.gouv.fr/validation/
MIT License
37 stars 10 forks source link

Update clap and gtfs structures #196

Closed antoine-de closed 4 months ago

antoine-de commented 5 months ago

with with cargo audit is fully happy (we were depending on structopt which is now integrated in clap

AntoineAugusti commented 5 months ago

This PR should not include https://github.com/etalab/transport-validator/pull/196/commits/ebb06e89bb5aa441c72cb6f1f11d0ffbcfa1d36f and other changes to removing legacy stats fields I guess

antoine-de commented 5 months ago

oups, I screwd up my git stuff

antoine-de commented 5 months ago

Do you mean cargo audit?

It could indeed be nice (but isn't this what is done by dependabot?)

AntoineAugusti commented 5 months ago

Do you mean cargo audit?

Yep!

It could indeed be nice (but isn't this what is done by dependabot?)

Not sure! Indeed Dependabot may be enough.

ptitfred commented 5 months ago

(I can help resolving the conflict if needed.)

antoine-de commented 5 months ago

oups no, no problem, I just work on this on my spare time, and completly forgot this PR 😁

antoine-de commented 5 months ago

can we merge this? It should not have any impact on transport.data.gouv.fr if I did not miss something :stuck_out_tongue_winking_eye:

AntoineAugusti commented 5 months ago

LGTM, maybe 🚢 it early next week?

antoine-de commented 4 months ago

Note: I added the test of non-default-features after the rebase on master, after the merge of #197