etalab / transport-validator

GTFS validator
https://transport.data.gouv.fr/validation/
MIT License
39 stars 10 forks source link

stops: add checks point_near_origin and point_near_pole #202

Open AntoineAugusti opened 2 months ago

AntoineAugusti commented 2 months ago

Consider adding 2 new rules validating latitude/longitude for stops. These 2 checks are part of the canonical GTFS Validator.

Rules

ℹī¸ 🙏 The rules are coming from Google's and MobilityData validators.

thbar commented 2 months ago

Implemented in #201, we're going to do a bit of live testing I think!

AntoineAugusti commented 2 months ago

@thbar #201 only outputs an error for (0, 0), this issue is about adding other checks

thbar commented 2 months ago

Sorry, I was a bit too fast !

Updating the doc for clarity.

thbar commented 2 months ago

I have updated the issue text (created separated tasks) to make it clearer for reviewers (since the issue title mentioned 2 checks, but the body did not).

Also @AntoineAugusti, I recommend an explicit attribution of the original implementation at the very top of the issues and PR, something like: "this is a backport of rules xyz from the MobilityData validator".

While not strictly required from a license point of view if I understand correctly, and while we already link there, a more explicit credit would be fair game in my opinion!

AntoineAugusti commented 2 months ago

Updated the description to reflect that point_near_origin has not been implemented.

We have been disallowing (latitude=0, longitude=0) for several years but we should consider updating the rule to follow what Google and then MobilityData are doing with the point_near_origin rule.

I recommend an explicit attribution of the original implementation

Sure, done ✅ 🎩