Bugfix/responsive - Githubissues

etalab / udata-gouvfr

Skin and customization for the French opendata portal based on udata. This project is not maintained anymore. Consider using https://github.com/etalab/udata-front as an alternative.

https://www.data.gouv.fr/fr/

GNU Lesser General Public License v2.1

26 stars 34 forks source link

Bugfix/responsive #605

Closed gmougeolle closed 3 years ago

gmougeolle commented 3 years ago

A tiny PR for some QOL improvements :

Pages no longer disappear if Vue cannot compile the HTML tree
Many responsive bugfixes, among which the return of the mobile suggest

ps : 🐴

gmougeolle commented 3 years ago

Thank you for all these bug fixes ! :)

Could you please add a line in the changelog ? :)

Additionally, in my local environment (using Responsive Design Mode on Firefox), the fix on scrolling doesn't seem to work (etalab/data.gouv.fr#353)

Having a changelog is very fancy ! 🎩

I didn't address etalab/data.gouv.fr#353 yet, it's a pretty hard to fix problem and it will have to wait until september :/

maudetes commented 3 years ago

Thank you for all these bug fixes ! :) Could you please add a line in the changelog ? :) Additionally, in my local environment (using Responsive Design Mode on Firefox), the fix on scrolling doesn't seem to work (etalab/data.gouv.fr#353)

Having a changelog is very fancy ! tophat

I didn't address etalab/data.gouv.fr#353 yet, it's a pretty hard to fix problem and it will have to wait until september :/

Ah sorry, my mistake! It's not critical at all anyway ;)

gmougeolle commented 3 years ago

@abulte Howdy 🤠 ! If you want to merge this (maybe not in master directly ?), I think it's ready to see the light