search

etalab / udata-gouvfr

Skin and customization for the French opendata portal based on udata. This project is not maintained anymore. Consider using https://github.com/etalab/udata-front as an alternative.
https://www.data.gouv.fr/fr/
GNU Lesser General Public License v2.1
25 stars 33 forks source link

Show private datasets and reuses on organization page #619

Closed maudetes closed 3 years ago

maudetes commented 3 years ago

Fix https://github.com/etalab/data.gouv.fr/issues/421 and https://github.com/etalab/data.gouv.fr/issues/420.

Show hidden datasets and reuses in same block as public ones. For private datasets, a badge is shown.

Fix tests accordingly (and make empty assets explicit in those).

Ex: image

maudetes commented 3 years ago

Correct me if I'm wrong, but this will show private datasets and reuses for everyone looking at the Organization page? I don't think this is what we want, only the members of the Organization should be able to see them (which will be fun to code ^^)

Nope, the datasets and reuses returned depend on can_view, here: https://github.com/etalab/udata-gouvfr/pull/619/files#diff-fadd3a9f6b19d9f032fbf2b69e194900629849fa2d31273c33a768e6367b9cddR90.

Users that can't view will be shown only visible datasets and reuses. Or did I miss something?

abulte commented 3 years ago

Users that can't view will be shown only visible datasets and reuses. Or did I miss something?

Nope, I missed the important part 😇