etaler / Etaler

A flexable HTM (Hierarchical Temporal Memory) framework with full GPU support.
BSD 3-Clause "New" or "Revised" License
89 stars 14 forks source link

Adding support for OpenCL inside docker #51

Closed alior101 closed 5 years ago

alior101 commented 5 years ago

Hi Martin, This PR add drivers for OpenCL inside docker.. Enjoy Lior

marty1885 commented 5 years ago

Thanks! I really admire your work. Yet.. if my very limited knowledge about docker is correct, wouldn't the patch cause docker not running on systems without a GPU (ex. CPU only servers)?

alior101 commented 5 years ago

no, it just adds the drive to access the GPU HW - you're still free to run it under cpu or GPU..

On Sun, Aug 4, 2019 at 10:38 AM Martin Chang notifications@github.com wrote:

Thanks! I really admire your work. Yet.. if my very limited knowledge about docker is correct, wouldn't the patch cause docker not running on systems without a GPU (ex. CPU only servers)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/etaler/Etaler/pull/51?email_source=notifications&email_token=AAXET3BKTU3CIVCPTATLF4TQC2BORA5CNFSM4IJDKLVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3P4JMI#issuecomment-517981361, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXET3FAPPQX2I2YDWGZVKTQC2BORANCNFSM4IJDKLVA .

marty1885 commented 5 years ago

I was fearing this will cause problems if no GPU is available. If that's the case, cool! merging.