why own llvm smallvector implementation ?

etaler / Etaler

A flexable HTM (Hierarchical Temporal Memory) framework with full GPU support.

BSD 3-Clause "New" or "Revised" License

89 stars 14 forks source link

why own llvm smallvector implementation ? #55

Closed alior101 closed 5 years ago

alior101 commented 5 years ago

Hi Martin, Can you please explain why you had to modify smallvec from the default llvm implementation ? Why not use the original unmodified one ? Thanks Lior

marty1885 commented 5 years ago

Hi, Because LLVM is a super huge dependency and the only thing I need is smallvec. And I don't expect everyone have LLVM installed on their system. Especially on Windows.

If you found the implementation is interfering with LLVM. I can move it into it's own namespace.

alior101 commented 5 years ago

ok. I adapted llvm pretty print for smallvec to ur impl - now it finally looks like normal array :) . I'll PR it in the next batch of changed.. 20190804_172836